Conversation
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
This type of sharing sends via an email and doesn't mark it as shared in the DB, correct?
| import java.util.function.Supplier; | ||
|
|
||
| import static org.labkey.api.query.QueryService.USE_ROW_BY_ROW_UPDATE; | ||
| import static org.labkey.query.reports.ReportServiceImpl.R_REPORT_CUSTOM_SHARING; |
There was a problem hiding this comment.
Suggest importing via ReportService instead of ReportServiceImpl
There was a problem hiding this comment.
That's weird it grabbed that import, Done.
|
|
||
| OptionalFeatureService.get().addFeatureFlag(new OptionalFeatureFlag(R_REPORT_CUSTOM_SHARING, | ||
| "Restore custom R report sharing", | ||
| "Allows R reports to be shared on a per user basis. This option will be removed in LabKey Server 26.7.", |
There was a problem hiding this comment.
Should this PR target 26.3 instead? If it goes to develop, it'll hit in 26.4 and ESR customers won't get any warning before its removal.
There was a problem hiding this comment.
I thought I had asked that question in standup and the response was 26.4, but you're right. I'll retarget this PR.
There was a problem hiding this comment.
Targeting 26.4 would likely be fine, but if that's where it first ships we should remove in 26.11 instead.
There was a problem hiding this comment.
Given that it's a fairly trivial change seems fine to go to 26.3.
Correct, reports sharing status stays the same. |
2 participants
Rationale
Puts the R report sharing UI under a deprecated feature flag. We'll plan to remove this feature in
26.7.