Skip to content

Refactor UUID#243

Open
aheev wants to merge 3 commits intoLadybugDB:masterfrom
aheev:refactor-uuid
Open

Refactor UUID#243
aheev wants to merge 3 commits intoLadybugDB:masterfrom
aheev:refactor-uuid

Conversation

@aheev
Copy link
Contributor

@aheev aheev commented Feb 26, 2026

This PR merges structs uuid and UUID. There's no point in having a separate class just to store static helper methods

@aheev
Copy link
Contributor Author

aheev commented Feb 26, 2026

@adsharma could you PTAL?

@adsharma
Copy link
Contributor

Trying to get 0.15.x out the door next few days. Let's work on the follow ups to #242 and defer this to post release.

Why do I say so? build-and-deploy.yml has many platforms and build configs. This push blocking CI tests a very small fraction of those. For example, it couldn't detect that commit 3026bbd would break macosx.

@adsharma
Copy link
Contributor

#246 - Didn't realize that uuid was one of them. My instinct is to undo whatever changes broke them. I'll also kick off a run with this PR to evaluate.

@aheev
Copy link
Contributor Author

aheev commented Feb 26, 2026

Trying to get 0.15.x out the door next few days. Let's work on the follow ups to #242 and defer this to post release.

Why do I say so? build-and-deploy.yml has many platforms and build configs. This push blocking CI tests a very small fraction of those. For example, it couldn't detect that commit 3026bbd would break macosx.

sure. Will push my changes in an hour. Fixing compilation issues

@adsharma
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants