Skip to content

[lua, sql, c++][module] NIN Era Audit#9466

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
CriticalXI:nin_era_audit
Feb 18, 2026
Merged

[lua, sql, c++][module] NIN Era Audit#9466
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
CriticalXI:nin_era_audit

Conversation

@CriticalXI
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Implements NIN relevant era accurate changes.
  • Adds two new mods:
    • YONIN_UTSUSEMI_ENMITY: Yonin gets a buff to utsusemi enmity in RoV but this logic was performed in the core. This mod applies the extra enmity by default in Yonin effect lua and the module removes the mod.
    • SANGE_MULTI_HIT: Implements era accurate Sange behavior, which is equivalent to Ranger barrage except with throwing ammo only and hit count is equal to your current shadows.
  • While investigating the proper Sange messaging, I noticed that Barrage messaging was also incorrect. Adds two new msg_basic entries to properly display "Player uses Barrage/Sange. The mob takes X points of damage."
  • Retail relevant Sange was missing the merit bonuses for additional levels in to Sange, this adds that functionaltiy.

Steps to test these changes

  • Load modules, see that NIN abilities and spells reflect listed changes

@Xaver-DaRed Xaver-DaRed merged commit 28cd33b into LandSandBoat:base Feb 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants