Conversation
This change makes it so that it loads the commit from the user's flake.lock This means that it will build of the commit that the user is on. The user can use `nix flake update spotatui` to update the commit they are on and when they next rebuild they will be put on the new version
| pname = "spotatui"; | ||
| version = "0.36.3-debug.1"; | ||
| src = ./.; | ||
| version = "0.37.2"; |
There was a problem hiding this comment.
Maybe deriving the version from Cargo.toml is better then hardcoding the version in
version = (builtins.fromTOML (builtins.readFile ./Cargo.toml)).package.version
Im not sure if that is the correct syntax but something like that
There was a problem hiding this comment.
I mean that probably is the correct as I overlooked the version (I just aligned it and didn't give much thought)
Since this is building form source personally it would make more sense to be {version}-{shortCommitHash}
This version "doesn't matter" as it's only really shown when the project is building
Since i have the version set to 0.0.0 that's the version that shows up during the compile. If you look at it and watch for when cargo get's to spotatui it still is loading 0.37.2 anyways
Id love to know what you think on this and what the "best approach" would be
There was a problem hiding this comment.
I forgot to add a photo of what the version I proposed looked liked so here that is now.
dirty isn't always going to be a thing and probably won't be as it's only showing up because I have changes in my git thus making it dirty
|
not sure if you are using mpris, but maybe mpris enablment could be incorporated. I have worked around this here: #150 |
Hmm interesting. I don't think this should be in the scope of this pr but I will look into making a followup pr if I have time |
3 participants
Summary
This change makes it so that it loads the commit from the user's flake.lock
This means that it will build of the commit that the user is on. The user can use
nix flake update spotatuito update the commit they are on and when they next rebuild they will be put on the new versionThis is relating to #143 (reply in thread)
Testing
Additional notes