fix: linux compatibility and testing#133
Conversation
bdchatham
left a comment
There was a problem hiding this comment.
My gut thinking is we should just have a workflow that goes through the happy path of setting up a project via devkit commands. I might have seen we already have something like this. It could be a standard set of commands that run across all platforms we support. Then we can move this hand-rolled go execution into the unit test suite.
we have a e2e test in the ci for this . But i don't why it didn't capture the issue. even though it runs on ubuntu |
|
That CI works because it's using the DOCKERS_HOST field which Graham looks to have added to support selecting the network based on. |
Motivation:
Support running devnet on both linux and mac
Modifications:
Linux: localhost (containers can access host via localhost)
macOS/Windows: host.docker.internal (required for Docker Desktop)
Added EnsureDockerHost() function that intelligently converts localhost URLs for container→host communication:
Includes regex fallback for malformed URLs
Result:
Testing:
unit tests
Open questions: