[stable32] refactor: files list config prefixes#6889
Open
backportbot-libresign[bot] wants to merge 12 commits intostable32from
Open
[stable32] refactor: files list config prefixes#6889backportbot-libresign[bot] wants to merge 12 commits intostable32from
backportbot-libresign[bot] wants to merge 12 commits intostable32from
Conversation
Update AccountService to use prefixed naming for files list related user configuration keys following the existing pattern used by id_docs_* and crl_* configs. Changes: - grid_view → files_list_grid_view - signer_identify_tab → files_list_signer_identify_tab - sorting_mode → files_list_sorting_mode - sorting_direction → files_list_sorting_direction - filter_modified → files_list_filter_modified - filter_status → files_list_filter_status This prevents namespace pollution and provides better organization for configuration keys. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Remove tests for inline migration logic that was moved to a proper database migration step. The migration is now handled by Version17001Date20260210000000. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update the filesSorting Pinia store to load and save configuration using the new files_list_ prefixed keys: - sorting_mode → files_list_sorting_mode - sorting_direction → files_list_sorting_direction This aligns the frontend with the backend refactoring and maintains consistency with existing patterns like id_docs_* configs. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update test expectations to match the new prefixed configuration keys (files_list_sorting_mode, files_list_sorting_direction) used in the refactored filesSorting store. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…d_view Update grid view toggle and conditional rendering to use the new prefixed config key files_list_grid_view in: - FilesList.vue: Main list view toggle button and state - FilesListVirtual.vue: Component selection based on view mode - VirtualList.vue: CSS classes for grid/list layout Maintains functionality while following the new naming convention. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update preview size calculation to use files_list_grid_view config key. The component now requests 128x128 previews for grid view or 32x32 for list view based on the new prefixed configuration key. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…er_identify_tab Update signer identification tab persistence to use the new prefixed config key files_list_signer_identify_tab. This maintains the user's last selected tab (email, account, etc.) across sessions using the consistent naming pattern. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Extend Version17001Date20260210000000 migration to automatically migrate user configuration keys from old unprefixed names to new prefixed format during app update. Migrates: - grid_view → files_list_grid_view - signer_identify_tab → files_list_signer_identify_tab - sorting_mode → files_list_sorting_mode - sorting_direction → files_list_sorting_direction - filter_modified → files_list_filter_modified - filter_status → files_list_filter_status The migration: - Queries users with old config keys - Copies values to new keys only if new keys don't exist - Removes old keys after successful migration - Handles both migration and cleanup cases - Runs once during update (not a repair step) This ensures existing users retain their preferences without any manual intervention when updating the app. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Import IQueryBuilder interface - Replace createParameter with createNamedParameter for better consistency - Use IQueryBuilder::PARAM_STR_ARRAY instead of Doctrine DBAL constant - Simplify query building by removing separate setParameter call Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Migration tests require complex database mocking and are typically not necessary for infrastructure code. The migration functionality is better validated through integration testing or manual verification. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6888