[stable33] fix: signing mode sync default

lib/Controller/AdminController.php

@@ -926,7 +926,7 @@ public function setSigningModeConfig(string $mode, ?string $workerType = null):
 				], Http::STATUS_BAD_REQUEST);
 			}
 
-			$this->saveOrDeleteConfig('signing_mode', $mode, 'async');
+			$this->saveOrDeleteConfig('signing_mode', $mode, 'sync');
 			$this->saveOrDeleteConfig('worker_type', $workerType, 'local');
 
 			return new DataResponse([

lib/Service/SigningCoordinatorService.php

@@ -22,7 +22,7 @@ public function shouldUseParallelProcessing(int $signRequestCount): bool {
 			return false;
 		}
 
-		$signingMode = $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'async');
+		$signingMode = $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'sync');
 		return $signingMode === 'async';
 	}
 }

lib/Service/Worker/WorkerConfiguration.php

@@ -21,7 +21,7 @@ public function __construct(
 	}
 
 	public function isAsyncLocalEnabled(): bool {
-		$signingMode = $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'async');
+		$signingMode = $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'sync');
 		if ($signingMode !== 'async') {
 			return false;
 		}

lib/Settings/Admin.php

@@ -80,7 +80,7 @@ public function getForm(): TemplateResponse {
 		$this->initialState->provideInitialState('tsa_password', $this->appConfig->getValueString(Application::APP_ID, 'tsa_password', self::PASSWORD_PLACEHOLDER));
 		$this->initialState->provideInitialState('docmdp_config', $this->docMdpConfigService->getConfig());
 		$this->initialState->provideInitialState('signature_flow', $this->appConfig->getValueString(Application::APP_ID, 'signature_flow', \OCA\Libresign\Enum\SignatureFlow::NONE->value));
-		$this->initialState->provideInitialState('signing_mode', $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'async'));
+		$this->initialState->provideInitialState('signing_mode', $this->appConfig->getValueString(Application::APP_ID, 'signing_mode', 'sync'));
 		$this->initialState->provideInitialState('worker_type', $this->appConfig->getValueString(Application::APP_ID, 'worker_type', 'local'));
 		$this->initialState->provideInitialState('envelope_enabled', $this->appConfig->getValueString(Application::APP_ID, 'envelope_enabled', '1') === '1');
 		$this->initialState->provideInitialState('parallel_workers', $this->appConfig->getValueString(Application::APP_ID, 'parallel_workers', '4'));

src/views/Settings/Settings.vue

@@ -16,7 +16,7 @@
 		<Validation />
 		<DocMDP />
 		<SignatureFlow />
-		<SigningMode />
+		<SigningMode v-if="false" />
 		<AllowedGroups />
 		<LegalInformation />
 		<IdentificationDocuments />

src/views/Settings/SigningMode.vue

@@ -98,7 +98,7 @@ export default {
 	data() {
 		return {
 			name: t('libresign', 'Signing mode'),
-			asyncEnabled: true,
+			asyncEnabled: false,
 			externalWorkerEnabled: false,
 			parallelWorkersCount: '4',
 			lastSavedParallelWorkers: '4',
@@ -118,7 +118,7 @@ export default {
 	methods: {
 		loadConfig() {
 			try {
-				const mode = loadState('libresign', 'signing_mode', 'async')
+				const mode = loadState('libresign', 'signing_mode', 'sync')
 				this.asyncEnabled = mode === 'async'
 
 				const workerType = loadState('libresign', 'worker_type', 'local')
@@ -130,7 +130,7 @@ export default {
 			} catch (error) {
 				console.error('Error loading signing mode configuration:', error)
 				this.errorMessage = t('libresign', 'Could not load configuration.')
-				this.asyncEnabled = true
+				this.asyncEnabled = false
 				this.externalWorkerEnabled = false
 				this.parallelWorkersCount = '4'
 			}

tests/php/Unit/Service/SigningCoordinatorServiceTest.php

@@ -37,7 +37,7 @@ public function testShouldUseParallelProcessingReturnsFalseForSingleSigner(): vo
 	public function testShouldUseParallelProcessingReadsConfig(string $mode, bool $expected): void {
 		$this->appConfig->expects($this->once())
 			->method('getValueString')
-			->with(Application::APP_ID, 'signing_mode', 'async')
+			->with(Application::APP_ID, 'signing_mode', 'sync')
 			->willReturn($mode);
 
 		$this->assertSame($expected, $this->service->shouldUseParallelProcessing(2));

tests/php/Unit/Service/Worker/WorkerConfigurationTest.php

@@ -31,7 +31,7 @@ public function testIsAsyncLocalEnabledRequiresBothConditions(): void {
 		$this->appConfig->expects($this->exactly(2))
 			->method('getValueString')
 			->willReturnMap([
-				[Application::APP_ID, 'signing_mode', 'async', 'async'],
+				[Application::APP_ID, 'signing_mode', 'sync', 'async'],
 				[Application::APP_ID, 'worker_type', 'local', 'local'],
 			]);
 
@@ -42,7 +42,7 @@ public function testIsAsyncLocalEnabledRequiresBothConditions(): void {
 	public function testIsAsyncLocalEnabledFalseWhenSigningModeNotAsync(): void {
 		$this->appConfig->expects($this->once())
 			->method('getValueString')
-			->with(Application::APP_ID, 'signing_mode', 'async')
+			->with(Application::APP_ID, 'signing_mode', 'sync')
 			->willReturn('sync');
 
 		$service = $this->makeService();
@@ -53,7 +53,7 @@ public function testIsAsyncLocalEnabledFalseWhenWorkerTypeNotLocal(): void {
 		$this->appConfig->expects($this->exactly(2))
 			->method('getValueString')
 			->willReturnMap([
-				[Application::APP_ID, 'signing_mode', 'async', 'async'],
+				[Application::APP_ID, 'signing_mode', 'sync', 'async'],
 				[Application::APP_ID, 'worker_type', 'local', 'remote'],
 			]);