Skip to content

fix: disable guest id hashing in setup#110

Merged
vitormattos merged 2 commits intomainfrom
fix/disable-guest-id-hashing
Apr 3, 2026
Merged

fix: disable guest id hashing in setup#110
vitormattos merged 2 commits intomainfrom
fix/disable-guest-id-hashing

Conversation

@vitormattos
Copy link
Copy Markdown
Member

@vitormattos vitormattos commented Apr 3, 2026

Summary

  • disable guests.hash_user_ids before creating or looking up guest users in assureGuestExists
  • restore the original guests.hash_user_ids value after each scenario so the helper does not leak app config state
  • root cause is nextcloud/guests commit 555cf1bcff192fe7bb5a77569aeb568093f6c774 (feat: Hash user IDs by default for improved privacy)

Validation

  • php vendor/bin/behat features/account/signature.feature:224 in LibreSign integration suite
  • forced guests.hash_user_ids=true before the downstream scenario and verified it was restored after the scenario
  • php vendor/bin/behat features/test.feature
  • composer psalm
  • composer cs:fix

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos merged commit 6dc5a65 into main Apr 3, 2026
10 checks passed
@vitormattos vitormattos deleted the fix/disable-guest-id-hashing branch April 3, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant