kintsugi: handle buildable folders? #135
kintsugi: handle buildable folders? #135anassalzurba wants to merge 2 commits intoLightricks:mainfrom
Conversation
Updated minimum xcodeproj dependency to 1.26.0 to ensure PBXFileSystemSynchronizedRootGroup support for Xcode 16 buildable folders.
This was written by cursor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling PBXFileSystemSynchronizedRootGroup objects in the Kintsugi project merge tool. This appears to be a new Xcode project file type that needs to be recognized and processed during project merging operations.
- Added
PBXFileSystemSynchronizedRootGroupto the list of recognized group types - Implemented a new handler method for adding file system synchronized root groups
- Updated the minimum xcodeproj dependency version to 1.26.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/kintsugi/apply_change_to_project.rb | Added support for PBXFileSystemSynchronizedRootGroup type in group processing and implemented the corresponding handler method |
| kintsugi.gemspec | Updated minimum xcodeproj dependency version from 1.19.0 to 1.26.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| containing_component[:product_group] = new_group | ||
| add_attributes_to_component(new_group, change, change_path) | ||
| when Xcodeproj::Project::PBXGroup | ||
| # Adding file system synchronized root groups to groups is handled by another part of the code. |
There was a problem hiding this comment.
This comment is vague and doesn't explain where or how this case is actually handled. Consider providing more specific information about which part of the code handles this scenario or what the expected behavior is.
| # Adding file system synchronized root groups to groups is handled by another part of the code. | |
| # No action is taken when attempting to add a file system synchronized root group to a PBXGroup. | |
| # This scenario is intentionally ignored because PBXGroups cannot contain file system synchronized root groups. |
|
it seems ok, did you check that it works? |
|
I didn't 😅 |
2 participants
This was written by cursor
@oryonatan