Don't crash milltask when no tool data file is specified #3791
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoe
reviewed
Feb 8, 2026
BsAtHome
force-pushed
the
fix_tooldata-save
branch
from
9b136d5 to
26245e2
Compare
smoe
approved these changes
Feb 9, 2026
Collaborator
smoe
left a comment
smoe
left a comment
There was a problem hiding this comment.
The chance that DB_SPINDLE_SAVE is NULL, may likely be ignored, indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a crash in milltask that happens when the ini-file lacks an entry for [EMCIO]TOOL_TABLE and a request is made to set a tool offset. The filename argument to tooldata_save() would be NULL and was naively dereferenced.