Skip to content

feat(roles/grafana): Add JWT support#207

Merged
NavidSassan merged 8 commits intomainfrom
feat/grafana-jwt
Apr 2, 2026
Merged

feat(roles/grafana): Add JWT support#207
NavidSassan merged 8 commits intomainfrom
feat/grafana-jwt

Conversation

@danyalberchtoldlf
Copy link
Copy Markdown
Contributor

No description provided.

grafana__bitwarden_collection_id: '{{ lfops__bitwarden_collection_id | default() }}'
grafana__bitwarden_organization_id: '{{ lfops__bitwarden_organization_id | default() }}'
grafana__cookie_samesite: 'lax'
grafana__auth_jwt: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort alphabetically

@danyalberchtoldlf danyalberchtoldlf marked this pull request as draft March 27, 2026 15:01
@danyalberchtoldlf danyalberchtoldlf marked this pull request as ready for review March 27, 2026 17:00
grafana__api_url: '{{ grafana__root_url }}'
grafana__auth_jwt: false
grafana__auth_jwt__priv_key_file: '/etc/grafana/jwt.key.priv'
grafana__auth_jwt__pub_key_file: '/etc/grafana/jwt.key.pub'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort alphabetically

size: 2048
type: 'RSA'
owner: 'apache'
group: 'icingaweb2'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont work on a host without icingaweb2. is it even needed, since it is copied to the icingaweb2 directory in roles/icingaweb2_module_grafana/tasks/main.yml?

when:
- 'grafana__https_config is defined and grafana__https_config | length > 0'

- name: 'generate JWT RSA private key'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only generate if grafana__auth_jwt is true?


| Variable | Description | Default Value |
| -------- | ----------- | ------------- |
| `icingaweb2_module_grafana__auth_jwt` | Enable JWT-based authentication for Grafana requests | `false` |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is wrong

@NavidSassan NavidSassan merged commit 6a2a767 into main Apr 2, 2026
5 checks passed
@NavidSassan NavidSassan deleted the feat/grafana-jwt branch April 2, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants