Skip to content

feat(resultsTable): use new table widget#7141

Merged
Eetwalt merged 29 commits intomainfrom
resultstable-cleanup
Feb 26, 2026
Merged

feat(resultsTable): use new table widget#7141
Eetwalt merged 29 commits intomainfrom
resultstable-cleanup

Conversation

@ElectricalBoy
Copy link
Collaborator

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked what this means perf (runtime, memory and include size) wise?

@ElectricalBoy
Copy link
Collaborator Author

ElectricalBoy commented Feb 24, 2026

have you checked what this means perf (runtime, memory and include size) wise?

using the same "Faker" test from sandbox linked in OP:

  • Lua runtime: ~70 ms increase
  • Lua memory: ~2.5 MB increase
  • include size: ~60 KB increase

test pages (perfutil does not pick up runtime info for some reason)

@hjpalpha
Copy link
Collaborator

hjpalpha commented Feb 24, 2026

do you plan to convert the html parts of the customs too?
if you want to test you can just preview https://liquipedia.net/starcraft2/HeRoMaRinE#Achievements

@ElectricalBoy
Copy link
Collaborator Author

do you plan to convert the html parts of the customs too?

in subsequent pr(s)
I think the size of this PR is big enough already

@hjpalpha
Copy link
Collaborator

do you plan to convert the html parts of the customs too?

in subsequent pr(s) I think the size of this PR is big enough already

fwiw it is only the sc2 one ;)

Copy link
Collaborator

@Eetwalt Eetwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly column configuration stuff based on the designs for this table:

Image

@Eetwalt
Copy link
Collaborator

Eetwalt commented Feb 25, 2026

#7149 can we get the new placement badges here too? 👀

@ElectricalBoy ElectricalBoy requested a review from Rathoz February 25, 2026 14:36
@Eetwalt Eetwalt merged commit 1fef740 into main Feb 26, 2026
7 checks passed
@Eetwalt Eetwalt deleted the resultstable-cleanup branch February 26, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants