feat(resultsTable): use new table widget#7141
Conversation
hjpalpha
left a comment
There was a problem hiding this comment.
have you checked what this means perf (runtime, memory and include size) wise?
using the same "Faker" test from sandbox linked in OP:
test pages (perfutil does not pick up runtime info for some reason) |
|
do you plan to convert the html parts of the customs too? |
in subsequent pr(s) |
fwiw it is only the sc2 one ;) |
Eetwalt
left a comment
There was a problem hiding this comment.
Mostly column configuration stuff based on the designs for this table:
a0a7dcc to
6233354
Compare
Co-authored-by: Eetu Rantanen <75437856+Eetwalt@users.noreply.github.com>
Co-authored-by: Eetu Rantanen <75437856+Eetwalt@users.noreply.github.com>
e080463 to
9546d6b
Compare
|
#7149 can we get the new placement badges here too? 👀 |
How did you test this change?
https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox8