Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Dota2 Rankings table from a legacy HTML table structure to the new Table2 widget system. The migration modernizes the table implementation while maintaining all existing functionality including graph toggling, responsive design, and data attributes required by JavaScript handlers.
Changes:
- Migrated from manual HTML table elements (HtmlWidgets.Table/Tr/Td/Th) to Table2 widget components (TableWidgets.Table/Row/Cell/CellHeader)
- Refactored SCSS styling to work with Table2's structure, removing legacy wrapper/border styles and updating selectors
- Added striped prop to Table2 widget with default value of true, allowing tables to opt-out of automatic striping
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| stylesheets/commons/RankingTable.scss | Updated styles to work with Table2 structure; removed legacy wrapper/border styles; simplified row and graph styling |
| lua/wikis/commons/Widget/Table2/TableBody.lua | Added support for disabling automatic row striping when BodyStripe context is nil |
| lua/wikis/commons/Widget/Table2/Table.lua | Added striped prop (default true) to allow tables to control automatic row striping |
| lua/wikis/commons/Widget/Ratings/List.lua | Migrated from legacy table structure to Table2 widget; restructured title as widget prop; converted all rows and cells to Table2 components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
reviewed
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the Rating table (used in dota2 rankings) to the new Table2 widget.
How did you test this change?
|dev=drd+ dev toolsBefore:

After:

Mainpage:
