Skip to content

feat: Add BasePrizePoolTable widget#7165

Open
hjpalpha wants to merge 16 commits intomainfrom
BasePrizePoolTable-widget
Open

feat: Add BasePrizePoolTable widget#7165
hjpalpha wants to merge 16 commits intomainfrom
BasePrizePoolTable-widget

Conversation

@hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Feb 26, 2026

Summary

Currently lots of wikis use manual wiki tabls for this.
Some use https://liquipedia.net/starcraft2/Module:BasePrizePoolTable (or copies of it).
Seems reasonable to create a standardized version of this which uses the new table widgets

open for better names for the Module ...
Also if you prefer a different input method just lmk and i can adjust it accordingly
(maybe not json stuff for perf reasons???)

How did you test this change?

{{#invoke:Lua|invoke|module=Widget/Factory|fn=fromTemplate|widget=BasePrizePoolTable|dev=hjp
https://liquipedia.net/starcraft2/User:Hjpalpha/wip26
image

image image

@hjpalpha hjpalpha requested review from a team as code owners February 26, 2026 10:30
@Eetwalt
Copy link
Collaborator

Eetwalt commented Feb 26, 2026

If I'm not mistaken, we aim to standardize the alignment for the new tables like:

  • default left align text and text like element (like placement here)
  • right align numbers (points and prize here)
  • center alignment generally only for images, scores and other special cases

@hjpalpha
Copy link
Collaborator Author

If I'm not mistaken, we aim to standardize the alignment for the new tables like:

  • default left align text and text like element (like placement here)
  • right align numbers (points and prize here)
  • center alignment generally only for images, scores and other special cases

tbh i just copied the alignment from the old module^^

fwiw in prize pool placements are center aligned

@Eetwalt
Copy link
Collaborator

Eetwalt commented Feb 26, 2026

fwiw in prize pool placements are center aligned

Oh sorry I think the results table also centers placements, so let's keep that here too.

Doesn't really make a difference as the pills take the full column width anyway but better to keep it consistent.

@fregerson
Copy link
Collaborator

fregerson commented Feb 27, 2026

Would an ability to set a hide-after be feasible? I would imagine in FFAs this can get really funky, example like in PUBGM - right now they use multiple columns to avoid it looking clunky

Another strange use of PrizePool Tables in Call of Duty - though I am not sure to what extent should we support these

@hjpalpha
Copy link
Collaborator Author

Would an ability to set a hide-after be feasible? I would imagine in FFAs this can get really funky, example like in PUBGM - right now they use multiple columns to avoid it looking clunky

Another strange use of PrizePool Tables in Call of Duty - though I am not sure to what extent should we support these

added support for secondary points, for overwriting the points header text(s) and for cutafter

imo:

  • multi column stuff like on pubg just looks shit, hence certainly not adding that
  • the by region stuff cod does seems bad too imo, why not just use 2 tables for that???

@hjpalpha hjpalpha requested review from a team and fregerson February 28, 2026 12:02
@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Mar 1, 2026

needs retesting (wiki kinda broken atm ...)

should improve annos in placement module

@hjpalpha hjpalpha requested review from a team and ElectricalBoy March 1, 2026 10:58
Copy link
Collaborator

@fregerson fregerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fregerson
Copy link
Collaborator

Actually after one night thought of another use case - do we want to cater to use case where this is used only to show Points?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants