Skip to content

feat:(TournamentsListing) Use new table design#7179

Open
mbergen wants to merge 7 commits intomainfrom
tournamentslisting-table2
Open

feat:(TournamentsListing) Use new table design#7179
mbergen wants to merge 7 commits intomainfrom
tournamentslisting-table2

Conversation

@mbergen
Copy link
Collaborator

@mbergen mbergen commented Feb 27, 2026

Summary

Apply the new table design to TournamentsListing

Major changes:

  • This table had a mobile variant, which obviously is gone now.
  • The behavior which cells grow is also different now (or rather, the old one had fixed widths for most cells)
    Best seen on a page like https://liquipedia.net/ageofempires/T90_Titans_League with `{{#vardefine:feature_dev|salt}} i'm happy about suggestions on how to improve this, my CSS skills are still limited

How did you test this change?

dev
image
image

image image image image

@mbergen mbergen requested a review from a team as a code owner February 27, 2026 17:50
@mbergen mbergen requested a review from a team as a code owner February 27, 2026 17:50
Copy link
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should be able to kick the majority of DivTable.scss if we are killing the mobile variant

@hjpalpha
Copy link
Collaborator

are we sure about kicking the mobile display for this?

@mbergen
Copy link
Collaborator Author

mbergen commented Feb 28, 2026

I think that we should be able to kick the majority of DivTable.scss if we are killing the mobile variant

Yes, that would be a followup PR

@hjpalpha
Copy link
Collaborator

I think that we should be able to kick the majority of DivTable.scss if we are killing the mobile variant

Yes, that would be a followup PR

need to make sure it isn't used anywhere (including outside git)

mbergen and others added 3 commits March 1, 2026 13:36
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants