feat(prizepool): update weight calculation in league of legends#7187
feat(prizepool): update weight calculation in league of legends#7187RonanHoogmoed wants to merge 5 commits intoLiquipedia:mainfrom
Conversation
ElectricalBoy
left a comment
ElectricalBoy
left a comment
There was a problem hiding this comment.
I would add extra modifier for highlighted tournaments, i.e., FST/MSI/Worlds
There was a problem hiding this comment.
Pull request overview
Updates the League of Legends prize pool “weight” calculation used for highlighting player results, shifting away from prize money (now often unavailable) and toward tier + tier-type based weighting to better reflect event importance.
Changes:
- Remove prize money from the LoL placement weight formula.
- Introduce
TIER_TYPE_MODIFIERand incorporatetournament_liquipediatiertypeinto weight calculation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ---@param tier string? | ||
| ---@param place integer | ||
| ---@param tierType string? | ||
| ---@return integer |
There was a problem hiding this comment.
calculateWeight can now return fractional values (e.g., with Qualifier = 0.25), so the EmmyLua annotation ---@return integer is no longer correct. Update it to ---@return number to match actual behavior and avoid incorrect LLS diagnostics.
| ---@return integer | |
| ---@return number |
There was a problem hiding this comment.
the pseudo ai is correct, the anno doesn't necessarily match what you return
ElectricalBoy
changed the title
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
are you sure you want to remove the money factor?
qith the new for,ula you get a 6th place for 10000000$ giving the same weight as a 6th place for 0$ ...
blame riot |
this will affect all tiers and events ... |
Understandable concern but I strongly believe this will be more representative. Most A-tier and B-tier events are within the Riot circuit and no longer have a communicated prizepool, this means that any results from 2026 and beyond will not be shown, and instead we'll get a list of B-, C-, and D-tier, mostly amateur/semi-pro events for players that achieved more than that. This already happens to players like Kisno and more clearly for Lyncas, where 2 years of tier 1 experience are ignored in favor for a C-tier event. The most extreme example I can find is Boukada, where a €200 third place in a cup in 2020 (and similar cases in 2018-19) are prioritized over 3 seasons in the LEC (highest level of competition). Prize money has never been valued much, if at all, in LoL esports so these changes should reflect what tournaments are held in higher regard by viewers and ensure modern tournaments will continue to show up. |
maybe something like (just my personal thought that this is better, fine to ignore me ;) ) |
sounds reasonable to me |
Appreciate the feedback! I'm also a fan of this solution so I just updated it to have some impact. |
Summary
League of Legends prize pools for major tournaments are no longer publicized, which means that tournaments going forward will no longer show up in the highlighted results for players, even if the achievement is more important (ex: Quid getting $200 for an off-season event being valued higher than a 4th place in the LCS). This means that existing tier 1 players will not have newer tournaments in their summarized achievements table, while upcoming players will not have tier 1 results in their results table if they make it to a tier 1 competition (ex: Sajed, who debuted in the LCS but a top 8, B-tier finish is considered more valuable due to $313 prizemoney).
Additionally, player results are often dominated by qualifiers for events instead of said event (ex: Geiger, who has 6 highlighted events which are qualifiers instead of the event itself), by adding weights to the tier types, these are now less valuable.
Changes are discussed and agreed on by the most active contributors: https://discord.com/channels/93055209017729024/276340346831765504/1470697786591674458
How did you test this change?
Difficult to change properly as many pages must be purged, but tiertype changes are directly taken from Hearthstone. Prizemoney should not return issues as it is removed from the equation altogether.
TIER_TYPE_MODIFIERis introduced to use the same weighting as notability guidelines, this aligns with previous consensus on 'value' of events and this should resolve the qualifier concern.I'm open to suggestions on how to properly test this.