create VOR table for cs wiki (fixed icons)#7188
Open
MischiefCS wants to merge 8 commits intoLiquipedia:mainfrom
Open
create VOR table for cs wiki (fixed icons)#7188MischiefCS wants to merge 8 commits intoLiquipedia:mainfrom
MischiefCS wants to merge 8 commits intoLiquipedia:mainfrom
Conversation
hjpalpha
requested changes
Feb 28, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
should switch to the new table design (Table2 widgets)
Logic.emptyOr with only 1 input —> use Logic.nilIfEmpty instead
you are often using string versions of HTML stuff, use widgets instead
imo parse the dates to timestamps instead of iso dates
Collaborator
|
further proposed changes: https://liquipedia.net/counterstrike/index.php?title=Module%3AValveOperationalRequirementsTable%2Fdev%2FMischiefCS&diff=3334603&oldid=3334466 the change in the date display is optional of course |
hjpalpha
reviewed
Mar 1, 2026
hjpalpha
approved these changes
Mar 1, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
lgtm modulo open comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is following on the previously introduced pr #5737 in which it adds the necessary tournament operation requirement details to relevant Valve Ranked tournaments. This is rather relevant due to the mass of details that can vary for each tournament and it is currently not tracked on the wiki.
This is mostly Martin's work and im just following on from what Rathoz had previously said needed to be changed https://discord.com/channels/93055209017729024/268719633366777856/1440408171129733160 by aligning the fontawesome icon call with that of the dota2 wiki.
Might not need to be a new PR but not sure how I can cause effect on the other.
How did you test this change?
Everything should still hopefully be aligned with the previous pr #5737 in terms of checks other than the icon creation.
This has been tested on wiki via https://liquipedia.net/counterstrike/Module:ValveOperationalRequirementsTable/dev/MischiefCS and https://liquipedia.net/counterstrike/User:MischiefCS/VorTest , internal_link and external_link were used for testing as the github icon isnt added in commons.
When testing all checks pass
