fix: remove wrong guard in DialectTranslation#3259
Merged
amokan merged 1 commit intoLogflare:mainfrom Mar 26, 2026
Merged
Conversation
nelsonmestevao
commented
Mar 9, 2026
|
|
||
| # Ensure all identifier values are strings, never null | ||
| defp pg_traverse_final_pass({"value" = k, nil}) when is_atom(k) do | ||
| defp pg_traverse_final_pass({"value" = k, nil}) do |
Contributor
Author
There was a problem hiding this comment.
Hi @amokan, this looks like a small contradiction. Since k is matched with "value", we know for a fact that is a string. Let me know if the original goal was something else 🙏
Contributor
There was a problem hiding this comment.
Let me revisit this because it is been a while since I've been in these weeds. I'll try my best to get to it tomorrow.
Contributor
Author
There was a problem hiding this comment.
Hi @amokan, what do you think? Safe to merge this one?
Contributor
There was a problem hiding this comment.
Sorry for the delay @nelsonmestevao . This looks good. I'll get it merged in and thank you!
nelsonmestevao
force-pushed
the
ne/typing
branch
11 times, most recently
from
9d593c8 to
4bc5988
Compare
nelsonmestevao
force-pushed
the
ne/typing
branch
3 times, most recently
from
4532bb0 to
eede1a4
Compare
nelsonmestevao
force-pushed
the
ne/typing
branch
3 times, most recently
from
367c7a6 to
e3aae27
Compare
nelsonmestevao
force-pushed
the
ne/typing
branch
from
e3aae27 to
de02657
Compare
amokan
approved these changes
Mar 26, 2026
|
|
||
| # Ensure all identifier values are strings, never null | ||
| defp pg_traverse_final_pass({"value" = k, nil}) when is_atom(k) do | ||
| defp pg_traverse_final_pass({"value" = k, nil}) do |
Contributor
There was a problem hiding this comment.
Sorry for the delay @nelsonmestevao . This looks good. I'll get it merged in and thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.