fix(sx1276): Restore channel frequency after RxChainCalibration in TX timeout workaround#1643
Closed
GastonDonikian wants to merge 1 commit intoLora-net:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in the TX timeout workaround where the channel frequency is not restored after
RxChainCalibration().Problem
In
SX1276OnTimeoutIrq(), the TX timeout workaround performs:SX1276Reset()- resets hardware registers to defaults (frequency registers become 0)RxChainCalibration()- reads frequency from registers (now 0), performs calibration, then "restores" the 0 valueAfter this sequence, the hardware frequency registers are left at 0 (or 868MHz from HF calibration), while
SX1276.Settings.Channelstill holds the correct value in RAM. Subsequent radio operations will use the wrong frequency.Solution
Restore the channel frequency from
SX1276.Settings.Channel(which is preserved in RAM) afterRxChainCalibration()completes.Related Issues