You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WIP. I removed the path option from the CLI. It can be added back if needed. There is right now no indication of the child process lobby server running.
This pull request adds the early version of the lobby system. The system does not currently include any countdowns. Instead the flow is:
--> Waiting for players until minimum players is reached
--> Voting for a map until everyone has voted
--> Selecting champions until everyone has selected
--> Game begins
The lobby does not yet actually launch the paladins server. It just marks the state as "game in progress".
Testing
Open the server list and press host server. Select "public server" and increase the minimum players to, for example, 4. The lobby server will open in the background and appear in the server list after some time. Clicking the server on the server list makes you join the lobby. I created a debug URL that I usually open in the browser: http://localhost:1420/debug-lobby The debug URL makes it possible to add new players and make their map and champion selections.
TODO
Better error handling
Indication of lobby server running in the background
Separate UI into components
Improve the look and responsiveness of UI
Kick players after long disconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. I removed the path option from the CLI. It can be added back if needed. There is right now no indication of the child process lobby server running.