Add explicit tests for Rejection Pass-Through and Value Extraction Consistency#4
Draft
Add explicit tests for Rejection Pass-Through and Value Extraction Consistency#4
Conversation
…nsistency Agent-Logs-Url: https://github.com/LuxciumProject/mapping-tools/sessions/9dc8c71a-07f1-4ed4-ae5b-79c7b645062c Co-authored-by: Luxcium <42672814+Luxcium@users.noreply.github.com>
…raction Consistency (Claim 7) Agent-Logs-Url: https://github.com/LuxciumProject/mapping-tools/sessions/9dc8c71a-07f1-4ed4-ae5b-79c7b645062c Co-authored-by: Luxcium <42672814+Luxcium@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Luxcium
April 5, 2026 07:18
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two TODO items in the Property Verification Strategy: CLAIM 6 (Rejection Pass-Through) had no isolated test proving
SettledLeftitems skip transformation, and CLAIM 7 (Value Extraction Consistency) lacked explicit tests defining the semantic contract betweengetValues(),getAllValues(), andtoArray().Rejection Pass-Through (
rejectionPassThrough.test.ts— 5 tests)transformFnis never called on already-rejected itemscurrentRejection: falsefor inherited errors vstruefor errors thrown in current stepindex,transformStep, anderrLookupcallback args are preserved correctly on pass-throughValue Extraction Consistency (
valueExtraction.test.ts— 13 tests)getValues()— returns only fulfilled values; empty array when all rejectedgetAllValues()— preserves array length;NULL_SYMBOLat rejected positionstoArray()— full settled metadata (status,index,transformStep)getValues().length <= getAllValues().lengthtoArray().length === getAllValues().lengthNULL_SYMBOLpositions ingetAllValues()align withstatus: 'rejected'intoArray()getValues()matches the fulfilled subset oftoArray()Baseline 253 → 271 tests, all passing.