Fix: [SD.Next] CLIP failing to build due to pkg_resources missing (setuptools)#1555
Fix: [SD.Next] CLIP failing to build due to pkg_resources missing (setuptools)#1555NeuralFault wants to merge 1 commit intoLykosAI:mainfrom
Conversation
…it's the setuptools constraint in UV_BUILD_CONSTRAINT.
Summary of ChangesHello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build failure for the CLIP component within SD.Next by strategically managing Python package dependencies. It introduces a robust solution to ensure that the correct setuptools version is used during the build process, preventing issues caused by breaking changes in newer setuptools releases. The change enhances the stability and reliability of the installation and update procedures for the affected package. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request addresses a critical build failure in SD.Next related to pkg_resources by introducing a PIP_CONSTRAINT hook. The changes correctly apply setuptools constraints during package installation and updates, ensuring compatibility with newer setuptools versions. The new ApplySetuptoolsConstraints method centralizes this logic, which is a good practice for maintainability. Overall, the changes are well-implemented and directly resolve the reported issue.
|
DO NOT MERGE YET, new issue found "Import: setuptools No module named 'distutils'" when launching |
Added PIP_CONSTRAINT hook so pip process used for building CLIP inherits the setuptools constraint in UV_BUILD_CONSTRAINT.
This fixes the issue of building of CLIP failing during install due to missing "pkg_resources" module due to it utilizing the latest version of setuptools which has that module removed.