Skip to content

GH-605: Review two#704

Open
utkarshg6 wants to merge 63 commits intoGH-605-review-1-basefrom
GH-605
Open

GH-605: Review two#704
utkarshg6 wants to merge 63 commits intoGH-605-review-1-basefrom
GH-605

Conversation

@utkarshg6
Copy link
Copy Markdown
Collaborator

@utkarshg6 utkarshg6 commented Sep 12, 2025

Note

Replace fingerprint-based pending-payables with sent/failed tx tracking and new receipt/status types; refactor scanners/scheduling, adjust blockchain receipt API, compute chain-based defaults, and drop the pending_payable table.

  • Accountant/Scanners:
    • Introduce DetailedScanType; replace ReportTransactionReceipts with TxReceiptsMessage and PendingPayableFingerprintSeeds with RegisterNewPendingPayables.
    • Revamp PendingPayableScanner with in-memory caches, recheck logic, and distinct handling for confirmations/reclaims/validation failures.
    • Rename ScanRescheduleAfterEarlyStopScanReschedulingAfterEarlyStop; refine retry/reschedule behavior.
    • Switch amount/gas fields to amount_minor/gas_price_minor; update comparisons and logs.
  • Blockchain:
    • process_transaction_receipts now returns a map keyed by TxHashByTable to TxReceiptResult using StatusReadFromReceiptCheck.
    • Update send flow and logs; minor wording tweak (gas price “computed by this Node”).
  • Data structures/Errors:
    • Add TxHashByTable, StatusReadFromReceiptCheck, TxBlock; rework TxStatus/FailureStatus with ValidationStatus and PreviousAttempts (serde support).
    • Refine RPC/Blockchain error kinds (split local/remote) and display.
  • DB/Migrations:
    • Compute default ScanIntervals per-chain; migrate scan_intervals accordingly.
    • Remove pending_payable table (migration 10→11); adjust schema and DAO usage.
  • Config/Validation:
    • Validate scan-intervals relationship and payment-thresholds; expose neighborhood/rate/scan settings.
  • Tests/Utils:
    • Extensive test updates; add serializer mocks, receipt builders, and helper utilities.

Written by Cursor Bugbot for commit 02d98fb. This will update automatically on new commits. Configure here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants