Add support for chat formatting (bold, italic, underline, etc)#2851
Closed
Skylandia wants to merge 8 commits intoMCCTeam:masterfrom
Closed
Add support for chat formatting (bold, italic, underline, etc)#2851Skylandia wants to merge 8 commits intoMCCTeam:masterfrom
Skylandia wants to merge 8 commits intoMCCTeam:masterfrom
Conversation
Skylandia
changed the title
Member
|
Have you tested this? |
Author
|
demo screenshot Still WIP, since the italics aren't properly applied in the screenshot. |
Author
|
Should be in a mergable state if nobody has any issues. edit: just kidding this is not mergable there are still issues |
Member
|
Are all the issues fixed? |
Member
|
@Skylandia What are the concrete issues you were facing? |
Copilot AI
added a commit
that referenced
this pull request
Mar 24, 2026
…through, obfuscated) Re-implements PR #2851 against the current System.Text.Json.Nodes codebase. Changes: - ChatParser.cs: Add FormattingCodes dict, update JSONData2String to propagate formatting codes alongside colors, update NbtToString for the NBT chat path (used in MC 1.20.4+), fix root-string shortcut to preserve formatting prefix - DiscordBridge.cs: Add GetDiscordText() converting § codes to Discord Markdown, handle unclosed formatting codes with end-of-string matching End-to-end tested against Minecraft 1.21.11 (MC 26.1) offline server. All 8 formatting types verified: bold(§l), italic(§o), strikethrough(§m), underline(§n), combined, nested, reset-via-false, obfuscated(§k). Co-authored-by: milutinke <441903+milutinke@users.noreply.github.com> Agent-Logs-Url: https://github.com/MCCTeam/Minecraft-Console-Client/sessions/65b0d230-287c-4ed8-9b3c-a5ea25411804
Member
|
I re-implemented this, will merge soon when it's fully tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs more testing.