Use spawn start method for multiprocessing inside the test to avoid deadlock/timeout#5213
Open
yuxuanzhuang wants to merge 3 commits intodevelopfrom
Open
Use spawn start method for multiprocessing inside the test to avoid deadlock/timeout#5213yuxuanzhuang wants to merge 3 commits intodevelopfrom
yuxuanzhuang wants to merge 3 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5213 +/- ##
========================================
Coverage 92.72% 92.72%
========================================
Files 180 180
Lines 22475 22475
Branches 3190 3190
========================================
Hits 20841 20841
Misses 1177 1177
Partials 457 457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxuanzhuang
force-pushed
the
timeout_not_again
branch
from
77452dc to
81b8ef5
Compare
yuxuanzhuang
force-pushed
the
timeout_not_again
branch
from
81b8ef5 to
7e9a99c
Compare
yuxuanzhuang
changed the title
Contributor
Author
|
Tested twice and passed. |
orbeckst
requested changes
Feb 6, 2026
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
I'd be happy to merge and see if it improves things.
Could you add a comment to the test (along #5191 (comment) ) explaining the changes and referencing issue/PR, just so that future us knows where to look. I might even leave the original code commented out in one case, just to see clearly what the workaround does, given that the current code is probably what most people would use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5191
Changes made in this Pull Request:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5213.org.readthedocs.build/en/5213/