Skip to content

Fix acoustic source and body force timing #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbryngelson wants to merge 5 commits into
base: master
Choose a base branch
from
+4,547 −3,829
Open

Fix acoustic source and body force timing #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a182b25
Fix acoustic source and body force timing
sbryngelson Feb 21, 2026
99a3717
Regenerate golden files for body force adaptive-dt tests
sbryngelson Feb 22, 2026
9eeb5a3
Regenerate golden files for all tests affected by timestep timing fix
sbryngelson Feb 22, 2026
2dd4392
Remove unused t_step parameter from s_acoustic_src_calculations
sbryngelson Feb 22, 2026
9827652
Merge branch 'master' into fix/time-stepping-order
sbryngelson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/simulation/m_acoustic_src.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,10 @@ contains
end subroutine s_initialize_acoustic_src

!> This subroutine updates the rhs by computing the mass, mom, energy sources
!! @param t_step Current time step
!! @param q_cons_vf Conservative variables
!! @param q_prim_vf Primitive variables
!! @param rhs_vf rhs variables
impure subroutine s_acoustic_src_calculations(q_cons_vf, q_prim_vf, t_step, rhs_vf)
impure subroutine s_acoustic_src_calculations(q_cons_vf, q_prim_vf, rhs_vf)

type(scalar_field), dimension(sys_size), intent(inout) :: q_cons_vf !<
!! This variable contains the WENO-reconstructed values of the cell-average
Expand All @@ -140,7 +141,6 @@ contains

type(scalar_field), dimension(sys_size), intent(inout) :: rhs_vf

integer, intent(in) :: t_step
#:if not MFC_CASE_OPTIMIZATION and USING_AMD
real(wp), dimension(3) :: myalpha, myalpha_rho
#:else
Expand All @@ -165,7 +165,7 @@ contains

integer, parameter :: mass_label = 1, mom_label = 2

sim_time = t_step*dt
sim_time = mytime

$:GPU_PARALLEL_LOOP(private='[j,k,l]', collapse=3)
do l = 0, p
Expand Down
1 change: 0 additions & 1 deletion src/simulation/m_rhs.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,6 @@ contains
call nvtxStartRange("RHS-ACOUSTIC-SRC")
call s_acoustic_src_calculations(q_cons_qp%vf(1:sys_size), &
q_prim_qp%vf(1:sys_size), &
t_step, &
rhs_vf)
call nvtxEndRange
end if
Expand Down
4 changes: 2 additions & 2 deletions src/simulation/m_start_up.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,13 +845,13 @@ contains
end do
end if

mytime = mytime + dt

! Total-variation-diminishing (TVD) Runge-Kutta (RK) time-steppers
if (any(time_stepper == (/1, 2, 3/))) then
call s_tvd_rk(t_step, time_avg, time_stepper)
end if

mytime = mytime + dt

if (relax) call s_infinite_relaxation_k(q_cons_ts(1)%vf)

! Time-stepping loop controls
Expand Down
141 changes: 90 additions & 51 deletions tests/016C1B8B/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions tests/016C1B8B/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading