-
Notifications
You must be signed in to change notification settings - Fork 132
Add CLI visualization command (./mfc.sh viz) #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbryngelson
wants to merge
18
commits into
MFlowCode:master
Choose a base branch
from
sbryngelson:viz-fast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,507
−20
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e5770cd
Add `./mfc.sh viz` command for CLI visualization of post-processed ou…
sbryngelson 32a9f29
Fix viz: validate variable name and fix lint/spelling issues
sbryngelson 72216c2
Fix MP4 frame directory to use output path instead of case directory
sbryngelson c145f73
Fix Silo-HDF5 reader to parse Named Datatype structure correctly
sbryngelson 7db7951
Fix multi-processor assembly and Silo data ordering
sbryngelson bd6b03d
Use imageio-ffmpeg for MP4 rendering instead of system ffmpeg
sbryngelson 9c762cb
Add documentation for ./mfc.sh viz command
sbryngelson b47865f
Address code review feedback from CodeRabbit
sbryngelson 10cf9e7
Fix --step input validation and clarify inclusive range in docs
sbryngelson 1b096f4
Guard LogNorm against non-positive data in log-scale rendering
sbryngelson 87b5769
Harden readers and CLI error handling
sbryngelson 38ee1ec
Add viz to CLI reference doc generation categories
sbryngelson 507777d
Harden binary reader: EOF check, header validation, varname union, st…
sbryngelson b40c011
Fix MP4 opts mutation, frame cleanup safety, silo skip warning
sbryngelson c17eaf0
Harden viz: record validation, error handling, and robustness
sbryngelson 3b93848
Guard LogNorm against NaN data, harden frame cleanup
sbryngelson 29f20a9
Fix KeyError in MP4 rendering and require --step for render
sbryngelson 87a74ae
Reuse first-step read and add diagnostic warnings for missing timeste…
sbryngelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.