NDBC functions convertsion #167
Draft
MShabara wants to merge 2 commits intoMHKiT-Software:developfrom
Draft
Conversation
Contributor
|
@MShabara, I am looking into the failing tests. They look like MATLAB -> Python -> MATLAB errors and are likely not related to any changes you made here. I'm planning to create a separate PR to fix the tests. |
Merged
Contributor
Contributor
|
@MShabara, I just merged the test changes into this PR to see if we can get the tests passing. |
simmsa
added a commit
that referenced
this pull request
Sep 23, 2025
Split PR #167 into wave module changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a MATLAB-native version of the core functionality provided by the NDBC utility module originally written in Python. The goal is to improve integration with MATLAB workflows, eliminate the need for cross-language dependencies, and enhance usability within a fully MATLAB-based environment.