Fix HTTP→HTTPS redirect handling in PyMISP API client #1383
+84
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMISP was returning API description pages instead of actual API responses when using HTTP URLs that redirect to HTTPS. The session.send() call wasn't following redirects, causing the client to receive the initial redirect response rather than the final redirected response.
Changes
allow_redirects=Truetosession.send()in_prepare_request()Backward compatible - HTTPS URLs continue to work unchanged. Addresses issue reported in #1034.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
misp.example.com/usr/bin/python python /tmp/test_redirect_fix.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.