IN-1475 Initial release of CDPS dashboard#8
Conversation
Why these changes are being introduced: * A stakeholder-approved set of data points will serve as the initial release of the CDPS dashboard How this addresses that need: * Update notebook.py to include all expected data points for the initial release * Update dependencies Side effects of this change: * None Relevant ticket(s): *https://mitlibraries.atlassian.net/browse/IN-1475
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Able to get this running by pulling inventory locations from AWS and running via ArcvhivematicaManagers role.
Looking good! No errors, works as expected. Nice work on porting all this logic over!!
One suggestion, take or leave it, would be removing the checkboxes for tables that don't utilize them for anything. I think they add a lot of visual noise, and removing them quiets things down quite a bit.
This can be done by adding selection=None to any mo.ui.table() def, e.g.:
mo.ui.table(file_bucket_data, selection=None),With checkboxes:
Without:
And as discussed in slack, looking forward to talking about workflows for marimo notebooks; we don't have many yet to pull from. e.g. when DataEng reviews are needed, versus stakeholders, how best to review marimo diffs, etc.
All that said, nice work, looking good.
This actually came up in stakeholder review of the prototype, good call and I will remove them until we have a use for them. Thanks! |
Pull Request Test Coverage Report for Build 23322129523Details
💛 - Coveralls |
3 participants
Purpose and background context
An initial release of the CDPS dashboard for final stakeholder review before shifting to the maintenance workflow described here
How can a reviewer manually see the effects of these changes?
To preview the notebook, run
make run-notebookIncludes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?