Skip to content

Add underlines to links in the body of news stories #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djanelle-mit wants to merge 8 commits into from
Closed

Add underlines to links in the body of news stories #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d2f0eee
Add new spotlight flavor of alert. Updated colors and implmemented in…
djanelle-mit Sep 24, 2025
9a4f4a2
Updated max width for images in spotlights
djanelle-mit Sep 24, 2025
4bb0200
Add ARIA label to button and tweak image size
djanelle-mit Sep 24, 2025
dd82f53
Remove link around spotlight post titles
djanelle-mit Sep 24, 2025
8915961
Update from aria-label to title attribute for button
djanelle-mit Sep 24, 2025
8804ef5
Incremented the version for the parent theme styling
djanelle-mit Sep 25, 2025
eecdb54
Add underline to news links
djanelle-mit Sep 25, 2025
c131068
Increment news style sheet version
djanelle-mit Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions web/app/themes/mitlib-child/inc/content-front.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,16 @@
$the_query->the_post();
?>

<div class="excerpt-post">
<aside aria-label="Featured content" class="mitlib-spotlight">
<?php if ( get_first_post_image() ) : ?>
<img class="excerpt-post__fig" src="<?php echo esc_attr( get_first_post_image() ); ?>" width="200" >
<img src="<?php echo esc_attr( get_first_post_image() ); ?>">
<?php endif; ?>
<div class="excerpt-post__body">
<h3><a href="<?php echo esc_url( the_permalink() ); ?>"><?php the_title(); ?></a></h3>
<div>
<h3><?php the_title(); ?></h3>
<?php custom_excerpt( 20, '...' ); ?>
</div>
</div>
<a class="btn btn-secondary" title="Read more about <?php the_title(); ?>" href="<?php echo esc_url( the_permalink() ); ?>">Read more</a>
</div>
</aside>

<?php
endwhile;
Expand Down
4 changes: 2 additions & 2 deletions web/app/themes/mitlib-news/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
Theme Name: MITlib News
Author: MIT Libraries
Version: 0.5
Version: 0.6
Description: A child theme of the MIT Libraries' parent, focused on News features and content.
Template: mitlib-parent

Expand All @@ -11,7 +11,7 @@ Template: mitlib-parent
.content-area a:link,
.content-area a:visited {
color: #000;
text-decoration: none;
text-decoration: underline;
}
.content-area a:hover,
.content-area a:active {
Expand Down
5 changes: 4 additions & 1 deletion web/app/themes/mitlib-parent/css/scss/modules/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ $color-guides-experts: $magenta-dark;
// Adding new color values until we can adjust the global variables above
$info-blue: #007499;
$success-green: #009900;
$spotlight-purple: #990099;

$info-border-color: $info-blue;
$info-icon-color: $info-blue;
Expand All @@ -160,4 +161,6 @@ $danger-border-color: $red;
$danger-icon-color: $red;

$success-border-color: $success-green;
$success-icon-color: $success-green;
$success-icon-color: $success-green;

$spotlight-border-color: $spotlight-purple;
31 changes: 25 additions & 6 deletions web/app/themes/mitlib-parent/css/scss/partials/_alerts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@
}
}

.mitlib-alert {
.mitlib-alert, .mitlib-spotlight {
border: 4px solid $info-border-color;
margin-bottom: 20px;
padding: 16px;
display: flex;

i {
> i {
margin-right: 12px;

&:before{
Expand All @@ -124,14 +124,13 @@
}

div > h3 {
font-weight: 700;
font-weight: 600;
margin-top: 2px;
font-size: 1.25rem;
}

p {
margin-bottom: 16px;

&:last-of-type {margin-bottom: 0 !important;}
margin-bottom: 16px;
}

.btn {
Expand Down Expand Up @@ -174,4 +173,24 @@
content: "\f00c";
}
}
}

.mitlib-alert {
p:last-of-type {margin-bottom: 0 !important;}
}

.mitlib-spotlight {
border-color: $spotlight-border-color;
column-gap: 24px;

img {
width: 100%;
max-width: 170px;
min-width: 100px;
height: 100%;
}

p {
padding-bottom: 4px;
}
}
2 changes: 1 addition & 1 deletion web/app/themes/mitlib-parent/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
Theme Name: MITlib Parent
Author: MIT Libraries
Version: 0.7
Version: 0.8
Description: The parent theme for the MIT Libraries' Pentagram-designed identity.

*/
Expand Down