Add underlines to links in the body of news stories#190
Merged
djanelle-mit merged 2 commits intomasterfrom Sep 26, 2025
Merged
Conversation
c131068 to
2127c34
Compare
matt-bernhardt
approved these changes
Sep 26, 2025
Member
matt-bernhardt
left a comment
There was a problem hiding this comment.
I couldn't bring myself to believe the line numbers being referenced here, so had to go look up the stylesheet in context. Yes, apparently this is actually the first rules that we define for the entire theme - link decoration styles, defined in a non-intuitive way.
I'm not going to block this, it will get the job done that we need to, but wow I really can't wait until we have a more rational stylesheet for this theme.
Author
|
@matt-bernhardt Absolutely... the entire news site's CSS is in dire need of a refactor! Hopefully a problem we can address in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer
As part of the work done to change the typeface from Open Sans to Neue Haas Grotesk, the underline to links in news stories was removed. Since no other affordance was added, it's impossible to tell at a glance that there are links to visit.
This work adds that underline back in.
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)