Adding wp_bulk_delete plugin to bulk delete old news posts#191
Adding wp_bulk_delete plugin to bulk delete old news posts#191djanelle-mit merged 2 commits intomasterfrom
Conversation
matt-bernhardt
left a comment
There was a problem hiding this comment.
Ah, I see the issue. The CI check we run (which is meant to check our locally-writen code for adherence to code standards) is finding the plugin contents. The things being flagged aren't an issue, they're stylistic, and we're comfortable not worrying about style issues in other people's code.
The change that's needed is that we need to add this new plugin to the ignore list in phpcs.xml in the repository root. You'll see a big long list of other plugins that we ignore in this way, wrapped up in <exclude-pattern> tags. The plugins go in alphabetical order to make maintenance easier, so you'll probably want to add an ignore for this plugin too, around line 78.
matt-bernhardt
left a comment
There was a problem hiding this comment.
Looks good - I didn't confirm what the plugin does, I'm trusting you worked that out with Darcy and have no concerns. From a code perspective, this all looks good - sorry I forgot about the ignore list when we talked last week.
Looking at the docs we maintain in this repo, we should probably have a how-to article about managing third-party code. It doesn't need to be part of this PR, and could just be a link to composer and wpackagist or something. I'll make a ticket in our backlog for this, I think.
Developer
We had a request to remove all news stories (across all post types) older than July 1, 2021. To explore this, we added this plugin to a multidev to experiment with it's functionality. We found the results satisfactory, and would like to move it to production.
This work introduces the wp_bulk_delete plugin to our Wordpress site.
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)