feat : disable rename button and dynamic imports#1040
Open
JoeMakuta wants to merge 3 commits intoMODSetter:devfrom
Open
feat : disable rename button and dynamic imports#1040JoeMakuta wants to merge 3 commits intoMODSetter:devfrom
JoeMakuta wants to merge 3 commits intoMODSetter:devfrom
Conversation
…nization in LayoutDataProvider
…nents with loading skeletons
|
@JoeMakuta is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 05030f6..fb72bb2
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (5)
• surfsense_web/components/editor-panel/editor-panel.tsx
• surfsense_web/components/hitl-edit-panel/hitl-edit-panel.tsx
• surfsense_web/components/layout/providers/LayoutDataProvider.tsx
• surfsense_web/components/layout/ui/right-panel/RightPanel.tsx
• surfsense_web/components/report-panel/report-panel.tsx
Owner
|
@JoeMakuta Thanks. Can you fix the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
FIX #1037
FIX #1016
FIX #1014
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR addresses three issues: it disables the rename button when the chat title hasn't changed, improves navigation logic for creating new chats by simplifying router sync handling, and implements dynamic imports for the
PlateEditorcomponent across multiple panels to improve performance by enabling code splitting and preventing SSR rendering issues.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/layout/providers/LayoutDataProvider.tsxsurfsense_web/components/layout/ui/right-panel/RightPanel.tsxsurfsense_web/components/editor-panel/editor-panel.tsxsurfsense_web/components/hitl-edit-panel/hitl-edit-panel.tsxsurfsense_web/components/report-panel/report-panel.tsx