More/code contribution 2026 02#464
Closed
westei wants to merge 121 commits intoMORE-Platform:developfrom
Closed
Conversation
Feature relative study start
add staging branch to Build-and-Deploy block
Merg Staging into Main
Staging into main
…ervation MORE-Platform#79: Added a new simple Garmin Observation
…connection settings
…onnection-issues
…epository-for-key-values MORE-Platform#95: Added participant key-value repository database migration
…backend into 128-studymanager-refactoring
…ackend into 128-studymanager-refactoring Resolved Conflicts: * `studymanager-services/src/main/resources/db/migration/V1_18_0__add_key_value_repo.sql
128 studymanager refactoring
…ype`. It also makes the `observation_id` filter optional (if `null` is parsed as `observation_id`)
…c_support-data-type-filter MORE-Platform#126: Elastic**Service extension
…on and implemented the new docker compose configs for operating with blended care
…vtion-visibility MORE-Platform#166: Changed default visibility of the Garmin Observation and implem…
…ager backend. It does not yet use observation groups in business logic (e.g. schedule calculation). It also does not yet provide support for observation groups for import and export of studies
* Observation Groups as new Entity
* does have a title and a purpose
* Observation and Interventions can have an optional observation group (0..1)
* Participants can be optionally assigned to observation groups (0..n)
* New ObservationGroupsService with an API to CRUD Observation Groups
* Extended API for Observation, Intervention and Participant for Observation Groups
* it is now possible to include Observation Groups in Group based lookups for Observations and Interventions in a Study. The semantic is the same as for StudyGroups.
* New `/studies/{studyId}/observationGroups` endpoint with full CRUD functionality
* Extended endpoints for observation, intervention and participant to provide the observation group ids for the requested entities
This also include Component Tests for the Repository. Extends Repository Tests of Observation, Intervention and Participants for the new functionalities. Adds UnitTests for the new Controller and extends UnitTests for the Participant, Observation and Intervention Controller to validate the correct mappings of the new observation group properties
…oups * Participant Timelines now use the participants observation groups to query for relevant Observations and interventions * Import/Export of study configuration now includes observation groups. ParticipantInfo also include ObservationGroup assignment Extended all relevant tests to assert the changed and extended behavior
Prefer use of Collections.empty**() Co-authored-by: Jan Cortiel <37823749+janoliver20@users.noreply.github.com>
MORE-Platform#180: Observation Groups for the MORE Study Manager Backend
…for closing. Also added a component test that triggered the
…nstraint-violation MORE-Platform#267: Wrong StudyId set for imported Observations and Interventions
MORE-Platform#274: Fixed a data validation bug
…ogging MORE-Platform#238: Implemented limesurvey logging
…nts so that also occurrencies of already started but still ongoing observations are created
…tionService.getLatestStartTime(..)` methods
…alisation-for-new-participants This changes the initialization for the data health for new participa…
# Conflicts: # studymanager-services/src/main/java/io/redlink/more/studymanager/scheduling/UpsertOccurredObservationsCron.java
Umm/develop/274 observation bug
* This adds support for deleting Data Health information in case a study is set back to DRAFT after data where collected during the PREVIEW state
Refactoring:
* StudyService does no longer implement all side effects when the study state is changed. It creates `StudyStateChangedEvent` and publishes them as Spring `ApplicationEvent`
* All affected Services now provide `@EventListener` that perform any necessary side effects. This includes the `IntegrationService`, `InterventionService` and `ObservationService`
* NOTE: The deletion of data in the ElasticIndex and data health data in the OccurredObservationRepository when a Study is transitioned from the PREVIEW to the DRAFT state is still done in the StudyService
* Adapted the UnitTest to validate that the events are triggered
…arget branch for the MR
…of StudyStateChanged Events
…nge-sideeffect-refactoring Clean DataHealth after Preview & Refactoring on how to deal with SideEffencts on Study State changes
…ns to be dynamic. The ApplicationContext is now used to lookup beans by id (`obervergation.getType()`) at the time of request. The bug was caused by a change in the bean initialization caused by removing some dependencies from the StudyService. Wit this change the initialisation order has no effect.
…on. Now mocking the ApplicationContext. Changed ErrorHandling in the implementation. The public getObservationFactory(..) is now the primary implementation. The private factory(Observation o) Method now ensures that a NotFoundException is thrown if the Optional of the public API is empty
Umm/300 app usage observation
…ry-lookup MORE-Platform#303: Make ObservationFactory lookup dynamic
Gmasek
approved these changes
Mar 9, 2026
Contributor
Gmasek
left a comment
Gmasek
left a comment
There was a problem hiding this comment.
please add license headers to new files
…e in the compile-test pipeline configuration as those are not needed in the target repository
Author
|
@Gmasek We had to create a new Pull Request as Pipelines do not run if they come from a remote repository. New Pull Request: #466 Now we contributed the code first by creating and merging to a branch in the local repository and created a Pull request from this local branch. We will need to do the same for the Gateway as we can not merge without a successful pipeline run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code-Contribution for the MORE Gateway for February 2026