Start unifying uvloop & winloop together (WINDOWS SUPPORT)#736
Open
Vizonex wants to merge 16 commits intoMagicStack:masterfrom
Open
Start unifying uvloop & winloop together (WINDOWS SUPPORT)#736Vizonex wants to merge 16 commits intoMagicStack:masterfrom
Vizonex wants to merge 16 commits intoMagicStack:masterfrom
Conversation
Author
|
Feel free to kill the workflows for now. Something doesn't seem right at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A once seen os-gate is finally going to be lifted. I think it's pretty BS that we waited a decade but I'm here now to bring all of this nonsense to a close. I don't think it was fair to begin with. All I wanted to do was scrape websites with tor back in my day and at that time my computer was a 2 cpu laptop, to me making windows support wasn't just a goal but a statement that anything is possible if you put your mind to it.
I have maintained my project winloop for around 3 years and I originally didn't want to bring windows parts here thinking that the chore or merging would be much more painful that I had anticipated.
My reason for bringing my fixes for windows back here has to do with the maintenance nightmare/catchup game. With a part-time job clenching my neck along with other projects that I've wanted to explore I'm bringing all my research back here. To put my very first pypi library that I really cared about to a close.
I want to give a huge thank you to @lschoe for helping me to unify different portions of code that I have originally written and another shoutout to everyone else who contributed to winloop. This work would not be possible without all of you.
As soon as this passes I will be able to start safely decommissioning winloop and redirect my developers & users to uvloop again this should also make projects needing both winloop & uvloop obsolete cutting a bunch of unwanted headaches.
In return I plan to help maintain the uvloop project. I believe that I can find new things to optimize in the future.
fixes #14
fixes #536
fixes #652
Also feel free to close #62 as obsolete.
Warning
I want as much help and as many reviewers as I can get. Do whatever it takes to point me in the right direction and I will do my best to follow.
Merging windows and posix together is a pain and we need to get start unifying a lot of posix-speific code if we want this to work.