Support for 0 padding, tolerance and duration#280
Open
anmatika wants to merge 1 commit intoMango:masterfrom
Open
Support for 0 padding, tolerance and duration#280anmatika wants to merge 1 commit intoMango:masterfrom
anmatika wants to merge 1 commit intoMango:masterfrom
Conversation
Setting 0 values on initilization for padding, tolerance and duration is not possible with the current implentation since 0 values will become their default values. For example padding set to 0 will become 256. Add support for 0 values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is by design or a bug in the library. If this is a bug please consider this PR.
Setting 0 values on initialization for padding, tolerance, or duration is not possible
with the current implementation since 0 values will become their default values.
For example, padding set to 0 will become 256.
If using the library so it would behave as an overlay menu, having a possibility to set 0 padding is important.
This PR will add the possibility to set 0 values for padding, tolerance, and duration.
For more info, there's an issue for this: #266