Open
Conversation
…ation. Put guard in updateHeadsUpDisplay
Contributor
Author
|
@sbvis would you be able to verify whether this also fixes the issues on macOS? |
Contributor
|
Yes, it is working and nolonger crashing on macos: |
Contributor
Author
Thanks for testing :) |
…ation. Put guard in updateHeadsUpDisplay
…synchronization logic
Only call setCurrentColorDataset when the picked dataset is valid and a project is not currently opening. Previously the code unconditionally updated the current color dataset in the DatasetPickerAction handler; this change prevents dataset changes from being applied while a project load is in progress, avoiding potential race conditions or invalid state during project open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes HUD-related crashes on Linux and macOS and adds support for selecting datasets to control point size and opacity in scatterplots, alongside existing position and color dataset selection. It introduces new dataset picker actions for point size and opacity, updates the heads-up display (HUD) logic to reflect these new controls, and ensures proper synchronization and connection management for these actions.
New dataset picker actions for point size and opacity:
Feature additions
_pointSizeDatasetPickerActionand_pointOpacityDatasetPickerActiontoDatasetsAction, including their initialization, filter functions, and integration into action lists. [1] [2] [3] [4]ScatterplotPluginto track_pointSizeDatasetand_pointOpacityDataset, including logic for updating and connecting/disconnecting these datasets when the source changes. [1] [2]UI and HUD improvements
updateHeadsUpDisplay()to include point size and opacity datasets, and prevent HUD updates while a project is opening. [1] [2]Synchronization and connection management
Scatterplot plugin lifecycle updates
These changes collectively improve the scatterplot plugin's flexibility and user experience by allowing dynamic control over point size and opacity based on loaded datasets.