Skip to content

feat(cli): add paper format option for PDF generation#1

Open
Marcin3 wants to merge 1 commit intomainfrom
feat/pdf-paper-format
Open

feat(cli): add paper format option for PDF generation#1
Marcin3 wants to merge 1 commit intomainfrom
feat/pdf-paper-format

Conversation

@Marcin3
Copy link
Copy Markdown
Owner

@Marcin3 Marcin3 commented Apr 11, 2025

Add --paper-format option to the PDF command to specify paper formats like "A4"
Update the capture options interface to include format parameter
Pass the format option to the page.pdf() method

References microsoft#31057

@Marcin3 Marcin3 force-pushed the feat/pdf-paper-format branch 2 times, most recently from abe5dfb to b291068 Compare April 11, 2025 21:12
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

- Add `--paper-format` option to the PDF command to specify paper formats like "A4"
- Update the capture options interface to include format parameter
- Pass the format option to the page.pdf() method
@Marcin3 Marcin3 force-pushed the feat/pdf-paper-format branch from b291068 to 871d626 Compare April 14, 2025 10:39
@github-actions
Copy link
Copy Markdown

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

39133 passed, 806 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant