Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a preview-side Search SPI so the editor can drive search highlighting and match navigation inside the rendered Markdown preview (closes #87).
Changes:
- Add
src/search.tsimplementing mark/unmark, match indexing, and preview-side counter info. - Expose the Search SPI on
window.__markeditPreviewSPI__for CoreEditor to call. - Add unit tests for the preview search behavior using
happy-dom, and addmark.jsas a dependency.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/search.ts |
New search/highlighting engine for the preview using mark.js, plus counter/index helpers. |
main.ts |
Exposes performSearch, setSearchMatchIndex, clearSearch, searchCounterInfo over a global SPI. |
types/global.d.ts |
Types the global SPI on window for TS consumers. |
types/markjs.d.ts |
Adds minimal mark.js type declarations. |
tests/search.test.ts |
Adds tests covering preview-mode counter behavior, search, index wrapping, and clearing. |
package.json |
Adds runtime dependency mark.js and dev dependency happy-dom for tests. |
tsconfig.json |
Suppresses TS deprecation warnings via ignoreDeprecations. |
yarn.lock |
Lockfile updates for newly added dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87. When review, focus on logic correctness only, majority of the code is AI-generated.