Skip to content

chore: normalize file permissions and replace non-ASCII characters#36

Open
StrongWind1 wants to merge 1 commit intoMatrixEditor:masterfrom
StrongWind1:fix/ascii-cleanup
Open

chore: normalize file permissions and replace non-ASCII characters#36
StrongWind1 wants to merge 1 commit intoMatrixEditor:masterfrom
StrongWind1:fix/ascii-cleanup

Conversation

@StrongWind1
Copy link
Contributor

chore: normalize file permissions and replace non-ASCII characters

Some source files have the executable bit set and several files contain Unicode typographic characters that have ASCII equivalents. This PR fixes both.

No functional changes. All tests pass.

Permissions

22 files changed from 0755 to 0644. All are regular .py, .toml, .rst, and .txt files.

Unicode replacements

Replaced typographic Unicode with ASCII equivalents in 27 files (13 source, 14 docs):

Name Codepoint Original Replaced with Count
em-dash U+2014 -- ~52
en-dash U+2013 - 2
smart double quotes U+201C, U+201D " " " 6
smart single quote U+2019 ' ' 5
right arrow U+2192 -> 11
section sign U+00A7 § S 8
tab 0x09 spaces 1

Also fixed a typo in smtp.py: donẃngrade (U+0175) to downgrade.

The following Unicode characters were kept in the RST docs where they render correctly in Sphinx HTML: ⚙️ in headings, in CLI examples, ►◄ in diagrams, for footnotes, for concatenation, for math.

Deleted

Removed tests/.gitkeep. The directory contains .py test files and does not need a placeholder.

File permissions (22 files):
- Set 644 on all source files that were incorrectly marked 755
  (executable bit) across dementor/, docs/, tests/, and root configs.
- Affected: __init__.py, filters.py, paths.py, servers.py, loader.py,
  protocols/{__init__,ftp,kerberos,ldap,llmnr,mdns,netbios,ntlm,
  quic,smtp,spnego}.py, tui/{completer,commands/{config,env,ipconfig}}.py,
  assets/Dementor.toml, docs/source/tui.rst, requirements.txt

Non-ASCII replacements in dementor/ and root files (13 files):
- Em-dash (U+2014) -> ' --' in comments and docstrings
- En-dash (U+2013) -> '-'
- Right arrow (U+2192) -> '->'
- Curly/smart quotes (U+201C/U+201D) -> straight quotes
- Section sign (U+00A7) -> 'S' for spec references
- Tab (0x09) -> spaces in mysql.py
- Fix 'donwngrade' typo (U+0175) in smtp.py
- Affected: Dementor.toml, config/{toml,util}.py, db/connector.py,
  loader.py, protocols/{ftp,ntlm,smtp,ssdp}.py,
  tui/{completer,commands/{config,database}}.py, pyproject.toml,
  tests/test_db.py

Non-ASCII replacements in docs/ (14 .rst files):
- Em-dash (U+2014) -> '--'
- En-dash (U+2013) -> '-'
- Right single quote (U+2019) -> straight apostrophe
- Intentionally kept: section sign, arrows, gear emoji, double
  vertical line, dagger, pointer arrows, greater-equal sign
  (these render well in Sphinx HTML output)

Deleted:
- tests/.gitkeep (unnecessary, directory contains .py test files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant