fix: enable Shift+Click text selection#5445
Open
lustsazeus-lab wants to merge 3 commits intoMatterHackers:mainfrom
Open
fix: enable Shift+Click text selection#5445lustsazeus-lab wants to merge 3 commits intoMatterHackers:mainfrom
lustsazeus-lab wants to merge 3 commits intoMatterHackers:mainfrom
Conversation
added 3 commits
March 6, 2026 01:23
The LoadItemThumbnail method was invoking the callback from background threads (inside Task.Run), causing bedHistory.Invalidate() to not refresh the menu items correctly on first try. Wrapping the callback in UiThread.RunOnIdle ensures it runs on the UI thread. Fixes MatterHackers#4959
Updates agg-sharp to include the Shift+Click text selection fix.
Author
|
Hi maintainers, this PR is mergeable and ready. Could you please review/merge? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1411 - Cannot select text using Shift + Mouse Click [$65].
The fix adds handling for Shift+Click in InternalTextEditWidget.OnMouseDown() to extend the selection when Shift is held down, consistent with the existing test TextSelectionWithShiftClick.