Open
Conversation
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
|
|
||
| Create a directory where TF-PSA-Crypto can put Python code that can be used by both TF-PSA-Crypto and Mbed TLS. This directory is intended for _project knowledge_, i.e. data that describes TF-PSA-Crypto in a form that Mbed TLS can consume. | ||
|
|
||
| Code in this directory may call standard Python functions (e.g. set/list/dict functions, `re` functions, …) but should generally not do I/O or import `mbedtls_framework` modules. This way the code is flexible with respect to how it's consumed. |
Contributor
Author
There was a problem hiding this comment.
should generally not do I/O or import
mbedtls_frameworkmodules
This was important for the dynamic loading hack in the original version of the outcome analysis split in Mbed-TLS/mbedtls#10676. But now that the directory is an ordinary directory on the load path, and the module is consumed through an ordinary import statement, I don;t think it matters anymore.
There are still some potential gotchas, but they're much weaker:
- The code may be consumed by TF-PSA-Crypto or by Mbed TLS, so it must not assume that the project root is TF-PSA-Crypto, and it must not try to load other modules from TF-PSA-Crypto (outside of the same
project_knowledgedirectory). - The code may be loaded with either Mbed TLS's version of the framework or TF-PSA-Crypto's version, so we must be careful when using a recent framework feature.
Just don't assume that the framework vintage is the one in TF-PSA-Crypto: when a module is used by an Mbed TLS script, it uses Mbed TLS's framework submodule. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
“Test coverage info” is a more accurate name, but “test case info” isn't wrong and it's not worth the hassle of changing the name. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This was referenced Apr 16, 2026
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository split for depends.py: objectives, design, plan