Update global type to window.cardano possibly undefined#666
Open
dmurawsky wants to merge 1 commit intoMeshJS:mainfrom
Open
Update global type to window.cardano possibly undefined#666dmurawsky wants to merge 1 commit intoMeshJS:mainfrom
dmurawsky wants to merge 1 commit intoMeshJS:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dmurawsky is attempting to deploy a commit to the MeshJS Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@dmurawsky please sync with main branch, i would merge it after that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We were getting a client-side error because the global type assumes window.cardano is defined but it isn't defined sometimes.
Affect components
@meshsdk/common@meshsdk/contract@meshsdk/core@meshsdk/core-csl@meshsdk/core-cst@meshsdk/hydra@meshsdk/provider@meshsdk/react@meshsdk/svelte@meshsdk/transaction@meshsdk/walletType of Change
Related Issues
Checklist
npm run test)npm run build)Additional Information