Improve distribution of helm chart by filippomc · Pull Request #835 · MetaCell/cloud-harness

filippomc · 2026-02-20T17:18:21Z

Closes CH-239

Implemented solution

Generation scripts and templates have been changed to include the new parameters and configuration

Added harness.image_name field to allow applications to use custom Docker image names instead of directory-based names
Added CLI arguments (--name, --chart-version, --app-version) to customize Helm chart metadata during deployment
Added publish skip conditions for Codefresh CI/CD to enable selective image publishing

How to test this PR

Check the test deployment:

the samples image should be named "sample" now, thanks to the new image_name parameter
New parameters are available on Codefresh

Sanity checks:

The pull request is explicitly linked to the relevant issue(s)
The issue is well described: clearly states the problem and the general proposed solution(s)
In this PR it is explicitly stated how to test the current change
The labels in the issue set the scope and the type of issue (bug, feature, etc.)
The relevant components are indicated in the issue (if any)
All the automated test checks are passing
All the linked issues are included in one Sprint
All the linked issues are in the Review state
All the linked issues are assigned

Breaking changes (select one):

The present changes do not change the preexisting api in any way
This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

There is no reason why deployments based on CloudHarness may break after the current update
This PR and the issue are tagged as alert:deployment

Test coverage (select one):

Tests for the relevant cases are included in this pr
The changes included in this pr are out of the current test coverage scope

Documentation (select one):

The documentation has been updated to match the current changes
The changes included in this PR are out of the current documentation scope

CH-166 fix syntax issue

CH-170 fix secrets upgrade

Release/3.0.0

…ployment tools

- Updated deployment configurations to include optional helm metadata arguments such as chart name, chart version, and app version in `codefresh-template-stage.yaml` and `codefresh-template-test.yaml`. - Refactored helm chart creation logic to support these new parameters in `helm.py`. - Added new field `image_name` in ApplicationHarnessConfig to allow custom image naming. - Updated OpenAPI and model documentation to reflect the new `image_name` field. - Added tests to validate the inclusion of helm metadata arguments and image name overrides in deployment configurations. - Cleaned up unused build steps in `codefresh-test.yaml` and removed redundant commands.

filippomc · 2026-02-20T17:18:43Z

deployment-configuration/codefresh-template-dev.yaml

    commands:
      - bash cloud-harness/install.sh
-      - harness-deployment $PATHS -d ${{DOMAIN}} -r ${{REGISTRY}} -rs '${{REGISTRY_SECRET}}' -n ${{NAMESPACE}} --write-env -e $ENV --cache-url '${{IMAGE_CACHE_URL}}' $PARAMS
+      - export HELM_META_ARGS="$( [ -n "${{HARNESS_CHART_NAME}}" ] && printf -- "--name %s " "${{HARNESS_CHART_NAME}}"; [ -n "${{HARNESS_CHART_VERSION}}" ] && printf -- "--chart-version %s " "${{HARNESS_CHART_VERSION}}"; [ -n "${{HARNESS_APP_VERSION}}" ] && printf -- "--app-version %s" "${{HARNESS_APP_VERSION}}" )"


Copilot

Pull request overview

This pull request improves the distribution of Helm charts by adding customization options for image names and chart metadata. The changes support custom image names for applications, allow overriding Helm chart metadata (name, version, appVersion), and add conditional publishing controls for CI/CD pipelines.

Changes:

Added harness.image_name field to allow applications to use custom Docker image names instead of directory-based names
Added CLI arguments (--name, --chart-version, --app-version) to customize Helm chart metadata during deployment
Added publish skip conditions for Codefresh CI/CD to enable selective image publishing
Added upgrade documentation for migrating from CloudHarness 2.x to 3.x
Added GitHub Copilot instruction files for better AI assistant integration
Version change in models library from 3.0.0 to 1.0.0

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
tools/deployment-cli-tools/ch_cli_tools/helm.py	Implements custom image name support and chart metadata merging logic
tools/deployment-cli-tools/ch_cli_tools/codefresh.py	Adds publish skip condition logic for controlling image publishing
tools/deployment-cli-tools/ch_cli_tools/utils.py	Adds null check to get_image_name function
tools/deployment-cli-tools/harness-deployment	Adds CLI arguments for chart metadata customization
tools/deployment-cli-tools/tests/test_helm.py	Adds tests for image name override and chart metadata features
tools/deployment-cli-tools/tests/test_codefresh.py	Adds tests for publish skip conditions and helm metadata args
tools/deployment-cli-tools/tests/test_skaffold.py	Updates tests to use dynamic image names from values
tools/deployment-cli-tools/tests/resources/applications/myapp/deploy/values-imagename.yaml	Test fixture for custom image name feature
libraries/models/pyproject.toml	Changes version from 3.0.0 to 1.0.0 (potential issue)
libraries/models/cloudharness_model/models/application_harness_config.py	Adds image_name field to ApplicationHarnessConfig model
libraries/models/api/openapi.yaml	Adds image_name field to API schema
libraries/models/docs/ApplicationHarnessConfig.md	Documents the new image_name field
docs/model/ApplicationHarnessConfig.md	Documents the new image_name field
docs/upgrades/2.x_3.x.md	New upgrade documentation for migrating from 2.x to 3.x
deployment-configuration/codefresh-template-*.yaml	Adds HELM_META_ARGS environment variable construction
deployment/codefresh-test.yaml	Generated file with updated build order and helm metadata args
applications/samples/deploy/values.yaml	Example usage of custom image_name and cloudharness-base dependency
.github/instructions/*.md	New GitHub Copilot instruction files for project guidance
openapitools.json	Deleted OpenAPI generator configuration
ch-166.patch	Deleted patch file
deployment-configuration/codefresh-template-stage-onpremise.yaml	Deleted on-premise deployment template

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tools/deployment-cli-tools/ch_cli_tools/helm.py

tools/deployment-cli-tools/tests/test_helm.py

libraries/models/pyproject.toml

docs/upgrades/2.x_3.x.md

tools/deployment-cli-tools/ch_cli_tools/helm.py

.github/instructions/tools.instructions.md

tools/deployment-cli-tools/ch_cli_tools/helm.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

filippomc and others added 8 commits January 8, 2025 10:44

Merge pull request #791 from MetaCell/fix/CH-166

784c630

CH-166 fix syntax issue

CH-170 fix secrets upgrade

6f3fc96

Merge pull request #793 from MetaCell/release/2.4.4

737d59c

CH-170 fix secrets upgrade

chore: cleanup

e1a99b0

Upgrade documentation

316b987

Merge pull request #834 from MetaCell/release/3.0.0

1977332

Release/3.0.0

feat: add comprehensive instructions for Copilot, E2E testing, and de…

3ed3a35

…ployment tools

filippomc commented Feb 20, 2026

View reviewed changes

filippomc added 3 commits February 20, 2026 18:22

CH-239 test fix

40b2a3a

CH-239 fix test pipeline

a69836a

chore: add oyaml to test requirements

a94b168

filippomc requested a review from Copilot February 20, 2026 17:33

Copilot started reviewing on behalf of filippomc February 20, 2026 17:33 View session

filippomc requested a review from alxbrd February 20, 2026 17:36

Copilot AI reviewed Feb 20, 2026

View reviewed changes

filippomc and others added 4 commits February 20, 2026 18:44

lint: correct formatting issues in multiple files

acf747a

Update libraries/models/pyproject.toml

9bc3eaa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/instructions/tools.instructions.md

9741ff8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

#836 CH-239 fix: handle empty image_name in get_image_name function

4da5e4e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Improve distribution of helm chart#835

Improve distribution of helm chart#835
filippomc wants to merge 15 commits intodevelopfrom
feature/CH-239

filippomc commented Feb 20, 2026 •

edited

Loading

Uh oh!

filippomc Feb 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

filippomc commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implemented solution

How to test this PR

Sanity checks:

Breaking changes (select one):

Possible deployment updates issues (select one):

Test coverage (select one):

Documentation (select one):

Uh oh!

filippomc Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

filippomc commented Feb 20, 2026 •

edited

Loading