Skip to content

Fix: remove signerMeta from the advanced permissions starter#86

Merged
mj-kiwi merged 1 commit intomainfrom
fix/remove-signer-meta
Mar 4, 2026
Merged

Fix: remove signerMeta from the advanced permissions starter#86
mj-kiwi merged 1 commit intomainfrom
fix/remove-signer-meta

Conversation

@mj-kiwi
Copy link
Contributor

@mj-kiwi mj-kiwi commented Mar 2, 2026

What?

  • remove the signerMeta from the advanced permissions starter

Why?

  • no signerMeta is return from the grant permission method

How?


Note

Low Risk
Low risk template fix that only changes how delegation parameters are read/validated; behavior should be unchanged aside from no longer failing on missing signerMeta.

Overview
Updates the advanced permissions starter’s RedeemPermissionButton to stop reading delegation data from permission.signerMeta and instead use permission.context and permission.delegationManager directly.

This removes the early error path for missing signerMeta and keeps validation focused on the required context/delegationManager fields before sending the delegated user operation.

Written by Cursor Bugbot for commit 5be4caf. This will update automatically on new commits. Configure here.

@mj-kiwi mj-kiwi requested review from a team as code owners March 2, 2026 04:25
Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @AyushBherwani1998 any context that we are missing here?

@mj-kiwi mj-kiwi merged commit 8b715af into main Mar 4, 2026
13 checks passed
@mj-kiwi mj-kiwi deleted the fix/remove-signer-meta branch March 4, 2026 20:11
@AyushBherwani1998
Copy link
Member

I was waiting for the monorepo to module template to get merged. As changing templates will bring in merge conflicts. For this to reflect in the CLI, we need to publish new version which is blocked by migration of monorepo PR.

I'll resolve conflicts on my PR.

@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Mar 5, 2026

@mj-kiwi @jeffsmale90 we should revert the PR. The templates are targeting the latest stable version 0.3.0, which doesn't follow the signerMeta. We don't have a stable version released after 0.3.0, and CLI only targets the stable version.

Ideally this should be done when updating templates and examples to next stable version release.

@AyushBherwani1998
Copy link
Member

The problem is arising because latest Flask release is not compatible with 0.3.0, given the changes done according to new ERC-7715 spec. We can release a new version 0.4.0 before the 1.0.0 as discussed in last sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants