docs: stop recommending add-third-party-script-directory!#80
docs: stop recommending add-third-party-script-directory!#80Metaxal merged 1 commit intoMetaxal:masterfrom
Conversation
|
Thanks! Is there another step that needs to be done to cherry-pick this for 8.12? (Assuming you agree, @Metaxal, but that was the point of splitting this off from #81.) cc @jbclements |
|
Unless there is a pressing bugfix here (I've lost track -- is there?) I think we should try to merge to regular master and see how it goes with internal use for one release cycle. |
|
This commit, merged as 570bc28, just comments out the part of the documentation that currently recommends that third-party packages use
That documentation change is all I propose cherry-picking for 8.12. My attempt at providing a mechanism that does reliably work is over in #81, and I agree that it seems better to have a release cycle to confirm that whatever is eventually merged does work out well in practice. I believe @Metaxal's 837921c last month already fixed the bug in 8.11[.1] that affected Debian, Guix, Nix, and probably others, and I'll plan to build a release candidate to make sure. |
|
Oh, shoot! I somehow thought this was the other pull request. And yes, this one does need to be explicitly merged, I see. I don't see who is the release manager for this repo, however. But yes, let's cherry-pick 1c44fd5 to the release branch! |
|
I agree that we should probably use 1c44fd5 for 8.12, so as to give us more time to test the new design. |
|
@Metaxal you're the release manager for the quickscript repos, you should be able to cherry-pick this for the release; to see what the commands should be, use Ryan's repo-manager-app, available at: https://pre-release.racket-lang.org/status/?repo=Metaxal/quickscript Let me know if you have any questions! |
|
Oh cool, I didn't know there's an interface to cherry pick!
…On Thu, Jan 11, 2024 at 12:17 AM John Clements ***@***.***> wrote:
@Metaxal <https://github.com/Metaxal> you're the release manager for the
quickscript repos, you should be able to merge this for the release using
the status page at
https://pre-release.racket-lang.org/status/?repo=Metaxal/quickscript
Let me know if you have any questions!
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMU2HBG6EFCS3U64TZCONDYN4VR5AVCNFSM6AAAAABBP2AWF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVHE3DSMJZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Done! |
I think this should be merged for the 8.12 release even if the fix for #73 isn't ready in time, or if we decide to hold it for more testing.