adjust use of qs-invalid-hook so that it gets used at runtime#84
Open
rfindler wants to merge 1 commit intoMetaxal:masterfrom
Open
adjust use of qs-invalid-hook so that it gets used at runtime#84rfindler wants to merge 1 commit intoMetaxal:masterfrom
rfindler wants to merge 1 commit intoMetaxal:masterfrom
Conversation
Owner
|
Seems fine to me. A test case would be nice for sure :) Feel free to merge when you are satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
string-constantssyntactic form is meant to be used only at runtime, not during any higher phases (as the choice of language won't be resolved when compiling the source code).This pull request is one way to bring back the use of
qs-invalid-hook. I'm not sure if it a good way to go. It might be better to just not translation this part, maybe.I also did not test out how this works so that should be done before we merge.