Open
Conversation
|
Hi Daniele, nice work! I had a rough look at everything, seems fine to me. Should I test the configs? (Hopefully tomorrow afternoon between Balfrin blockages.) I would prioritize |
|
Quick update: I tried to run the configs, but am getting some errors. More to follow... |
|
Ok, it could be that the errors I had at first were related to the fact that balfrin was still down when I launched the jobs. So I made a new clone, but got some errors there too. Claude Code suggested a small change, after which both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR generalizes verification to use a more generic truth source instead of analysis-only inputs, so forecasts can be compared against either analysis zarr data or observations. It also updates the workflow, plotting/verification scripts, and config schema/docs to use the new truth interface consistently.
Missing features: