Transition to classgraph lib for reflections#5843
Open
Big-Iron-Cheems wants to merge 4 commits intoMeteorDevelopment:masterfrom
Open
Transition to classgraph lib for reflections#5843Big-Iron-Cheems wants to merge 4 commits intoMeteorDevelopment:masterfrom
Big-Iron-Cheems wants to merge 4 commits intoMeteorDevelopment:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
TODO: see if the code can be improved further
NOTE: var is used to suppress a comp-time warning of `toList()`
Removes the intermediate Comparator, StringBuilder and packets list
Big-Iron-Cheems
force-pushed
the
feat/classgraph
branch
from
1ed90c6 to
aa97f7b
Compare
Deduplicate @PostInit/@preinit methods across all package scans before execution. Methods were executed multiple times when the same class appeared in multiple addon package scans. Fixes NPE in TexturePacker caused by GuiRenderer.init() running twice.
Collaborator
Author
|
This should fix all the previous issues, more testing is appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Replace the Reflections lib with Classgraph, as the former is unmaintained.
PacketUtilsUtilwas rewritten such that the file is written all at once, leveraging Java NIO utils.Order of the packets is still the same as before.
Related issues
None.
How Has This Been Tested?
Loading several 1.21.10 addons and running
PacketUtilsUtil.Checklist: